jely2002 / youtube-dl-gui

A cross-platform GUI for youtube-dl made in Electron and node.js
GNU Affero General Public License v3.0
6.41k stars 443 forks source link

Windows 7 #418

Open rsauve opened 1 year ago

rsauve commented 1 year ago

Describe the bug Queuing video in Open video Downloader under Windows 7 produces an error. Video can not be downloaded. This error appears when adding/queuing video:

Path to video <eg: https://www.youtube.com/watch?v=MMB2Vw9gtSo> Error! Binaries missing/corrupted Please restart the app and disable antivirus

This error occurs in all instances of Windows 7 that I have tried. I disabled antivirus and ran Open Video Downloader again but continued to get the same error message.

To Reproduce Steps to reproduce the behavior:

  1. Install Open Video Downloader or run the portable edition in Windows 7.
  2. Open a Youtube video.
  3. Queue/Add a Youtube video in Open Video Downloader.
  4. See the error as described above.

Expected behavior Video should queue and be ready for download.

Screenshots Screenshot? Great I have a couple. How do I get a screenshot into this bug report?

Additional info (please complete the following information):

2022/09/16 Update Comparing a Windows 10 installation against a Windows 7 installation shows that two files are missing from the Windows 7 installation in the following path: %localappdata%\Programs\youtube-dl-gui\resources\app.asar.unpacked\binaries\

  1. yt-dlp.exe
  2. ytdlVersion

I added the missing files to the Windows 7 installation and the program worked. Though you can not open or run the downloaded video file directly from the program. However, the video file does successfully download and can be accessed via Windows Explorer. Buggy but works.

hayguen commented 1 year ago

same problem on Windows 10. solution is quite similar as in issue https://github.com/jely2002/youtube-dl-gui/issues/389 for Linux (and WSL)

downloaded yt-dlp.exe from https://github.com/yt-dlp/yt-dlp/releases and copied it to C:\Users\USERNAME\AppData\Local\Programs\youtube-dl-gui\resources\app.asar.unpacked\binaries

unfortunately, the full path was shortened with ".."s in the error details dialog; thus not fully readable nor copyable as text.

however, now runs fine :-)

rsauve commented 1 year ago

"unfortunately, the full path was shortened with ".."s in the error details dialog" %localappdata%\Programs\youtube-dl-gui\resources\app.asar.unpacked\binaries\

Using the %localappdata% environment variable is more generic, works with most versions of Windows.

My first post was created on 14/09/2022. To date, no response from the maintainers of this project. Is this project dead?

rsauve commented 1 year ago

22/04/2023 no response. This project is dead. Checkout Videomass: https://github.com/jeanslack/Videomass

aidenszolosi commented 1 year ago

I know this is awfully late but I downloaded this app today and did some troubleshooting and was able to get it to work. First download the latest win64 distribution of this https://github.com/BtbN/FFmpeg-Builds/releases Then head to C:\Users\%username%\AppData\Local\Programs\youtube-dl-gui\resources\app.asar.unpacked\binaries Unpack the Bin folder from ffmpeg into the binaries folder. Restart the application and it should work from there. Note: I did alot of troubleshooting before hand and may have done another vital step that I'm overlooking. Let me know if this solution works for anyone else.

rsauve commented 1 year ago

Thank you for the update aidenszolosi. I tried your instructions in Windows 7 and Windows 10 (Virtualbox (VMs). Both produced the same error:

Open-Video-Downloader-Error

I downloaded and installed Open Video Downloader. I downloaded and unzipped ffmpeg-master-latest-win64-gpl.zip. I copied the ffmpeg bin files from: D:\Users\%username%\Downloads\ffmpeg-5.1.2-full_build\bin\ ffmpeg.exe ffplay.exe ffprobe.exe

to: C:\users\%username%\AppData\Local\Programs\youtube-dl-gui\resources\app.asar.unpacked\binaries\ AtomicParsley.exe ffmpeg.exe ffplay.exe ffprobe.exe

No go. Open Video Downloader is still not working. Perhaps there is a missing step or two.

aidenszolosi commented 1 year ago

Thank you for the update aidenszolosi. I tried your instructions in Windows 7 and Windows 10 (Virtualbox (VMs). Both produced the same error:

Open-Video-Downloader-Error

I downloaded and installed Open Video Downloader. I downloaded and unzipped ffmpeg-master-latest-win64-gpl.zip. I copied the ffmpeg bin files from: D:\Users%username%\Downloads\ffmpeg-5.1.2-full_build\bin ffmpeg.exe ffplay.exe ffprobe.exe

to: C:\users%username%\AppData\Local\Programs\youtube-dl-gui\resources\app.asar.unpacked\binaries AtomicParsley.exe ffmpeg.exe ffplay.exe ffprobe.exe

No go. Open Video Downloader is still not working. Perhaps there is a missing step or two.

Interesting. Sorry to hear that. For all the files in "C:\users%username%\AppData\Local\Programs\youtube-dl-gui\resources\app.asar.unpacked\binaries" other than atomic parsley I downloaded the newest version online and did not use what was provided in the distribution. Potentially the yt-dlp.exe needs redownloaded as well like how @hayguen said.

Another step I did which may have helped me was using Chocolatey to force reinstall ffmpeg. I then added this folder with the exes to my environment variables under the path environment. This may be crucial to this working properly. I can open cmd from anywhere and type ffmpeg and it works so I wonder if this has any affect for you.

Thanks for your response and I hope to help get this working for you soon.

aidenszolosi commented 1 year ago

Could you open the download log and send a screenshot of that as well?