jely2002 / youtube-dl-gui

A cross-platform GUI for youtube-dl made in Electron and node.js
GNU Affero General Public License v3.0
6.41k stars 443 forks source link

FixMe: Not Showing Download-Progress (modules/download/DownloadQuery.js:176) #450

Open code-of opened 1 year ago

code-of commented 1 year ago

On downloading fragmented Video the download progress is logged but not reflected onto the progressbar.

  1. Download any .m3u8 indexed fragmented video
  2. Watch the logger logging the percentage.
  3. GUI-Progressbar gets stuck on "- Setting up environment -"

Expected behavior

The progressbar should indicate the progress during download.

The Fix-Up:

To fix this issue the comparison liveDataArray.length > 10 needs to be changed to liveDataArray.length > 12, like shown below on line 175 of modules/download/DownloadQuery.js .

/*172*/                let liveDataArray = liveData.split(" ").filter((el) => {
/*173*/                    return el !== ""
/*174*/                });
/*175*/                if (liveDataArray.length > 12) return;
/*176*/                liveDataArray = liveDataArray.filter((el) => {
/*177*/                    return el !== "\n"
/*178*/                });

modules/download/DownloadQuery.js:175

Cheers and kind regards !

@jely2002 @itscaro @StefanLobbenmeier @NebelNidas

StefanLobbenmeier commented 1 year ago

Thanks for already investigating a fix! Feel free to create a PR to my fork, i will gladly release it

code-of commented 1 year ago

Created a PR to your fork, plus added the adjustment necessary to reflect DL-Speed and ETA onto the card-view.

Kind regards !

StefanLobbenmeier commented 1 year ago

Please try out the release: https://github.com/StefanLobbenmeier/youtube-dl-gui/releases/tag/v2.4.8