Closed drizzentic closed 3 months ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
The recent updates to the project include changing the environment setting from "production" to "development" in the configuration file, enhancing the LogsCtrl
function with a null check for a textarea
element, introducing conditional script inclusion based on the isLocal
variable in the index.ejs
file, and adding a new application element for @jembi/openhim-sidebar
in the microfrontend layout.
File Path | Change Summary |
---|---|
packages/legacy-app/app/config/default.json |
Updated environment setting from "production" to "development" . |
packages/legacy-app/app/scripts/controllers/logs.js |
Added a null check for textarea element before scrolling when tailLogs is true. |
packages/root-config/src/index.ejs |
Introduced conditional rendering to include a script block based on the isLocal variable. |
packages/root-config/src/microfrontend-layout.html |
Added a new <application> element for @jembi/openhim-sidebar within the <route> block. |
sequenceDiagram
participant User
participant App
participant Config
participant LogsCtrl
participant Layout
User->>App: Load Application
App->>Config: Read Environment Setting
Config-->>App: Return "development"
App->>LogsCtrl: Initialize LogsCtrl
LogsCtrl->>LogsCtrl: Check textarea element
LogsCtrl-->>App: Initialization Complete
App->>Layout: Render Layout
Layout-->>App: Include @jembi/openhim-sidebar if path is #!/portal
In the world of code, a change so bright,
From "production" to "dev", we set the light.
Logs now scroll with a careful glance,
And scripts conditionally join the dance.
A sidebar appears in the portal's view,
Enhancing the journey for me and you.
Hoppy updates, swift and true! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share Tips
review
@drizzentic, I will now review the changes made in the pull request regarding the addition of the sidebar to the portal page. Thank you for using CodeRabbit and for your support!
Summary by CodeRabbit
New Features
@jembi/openhim-sidebar
) to the portal layout for improved navigation.Bug Fixes
textarea
element in the logs view to prevent errors.Configuration
Enhancements