Update enum values for OpenHIM Apps type

jembi / openhim-core-js

The Open Health Information Mediator core component. OpenHIM Support: Post your query on OpenHIE Discourse using the #openhim tag https://discourse.ohie.org/

http://openhim.org

Mozilla Public License 2.0

69 stars 69 forks source link

Update enum values for OpenHIM Apps type #1216

Closed medchedli closed 8 months ago

medchedli commented 9 months ago

This pull request proposes modifying the Apps schema's type attribute to:

New enum values: Replace ['link', 'embedded'] with ['internal', 'external', 'esmodule'].

However, I'd like to open a discussion about alternative naming options :

built-in: OpenHIM Console core module or internal pages
shortcut: link to an external web page or app
in-browser-module: link to one of Jembi's or third-party bundled ESModules

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0ef8191) 86.78% compared to head (60cdd8c) 86.76%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1216 +/- ## ========================================== - Coverage 86.78% 86.76% -0.02% ========================================== Files 89 89 Lines 6024 6024 ========================================== - Hits 5228 5227 -1 - Misses 796 797 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.