search

jembi / openhim-core-js

The Open Health Information Mediator core component. OpenHIM Support: Post your query on OpenHIE Discourse using the #openhim tag https://discourse.ohie.org/
http://openhim.org
Mozilla Public License 2.0
69 stars 69 forks source link

TB 389:Add capability to generate and enrich default import map with links to external apps #1223

Closed ItsMurumba closed 5 months ago

ItsMurumba commented 7 months ago

Add capability to allow for the importmap to be enriched with new links for all external apps that do not exist in the monorepo but are already registered within openhim core.

The PR introduces an endpoint used to fetch transformed/enriched import map file

Summary by CodeRabbit

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.85%. Comparing base (c5990f5) to head (076dd73).

:exclamation: Current head 076dd73 differs from pull request most recent head 8879c04. Consider uploading reports for the commit 8879c04 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1223 +/- ## ========================================== + Coverage 86.75% 86.85% +0.10% ========================================== Files 90 90 Lines 6024 6041 +17 ========================================== + Hits 5226 5247 +21 + Misses 798 794 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

coderabbitai[bot] commented 5 months ago

[!WARNING]

Rate Limit Exceeded

@drizzentic has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 21 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 2cc12e1ac1d1034ff10d2e5a93b073f39c96e782 and 8879c046a1be3d3c4bbd7c893c37df29ef499c5b.

Walkthrough

The recent updates bring a cohesive integration of a new openhimConsoleBaseUrl configuration setting across multiple configuration files, enrich the docker-compose.yml with additional authentication environment variables, and expand the API capabilities by introducing a new endpoint for import maps. These modifications also encompass adjustments to test suites and constants to accommodate the new functionalities and configurations.

Changes

Files Change Summary
.gitignore Added DockerfileARM to the ignore list.
config/default.json
config/development.json
config/test.json		 Added openhimConsoleBaseUrl setting with the value "http://localhost:9000".
infrastructure/docker-compose.yml Updated with environment variables for authentication settings and OpenHIM console base URL.
src/api/apps.js Introduced DEFAULT_IMPORT_MAP_PATHS import and added getTransformedImportMap for app data retrieval.
src/constants.js Added OPENHIM_CONSOLE_BASE_URL constant and defined DEFAULT_IMPORT_MAP_PATHS.
src/koaApi.js Included a new ImportMaps endpoint in the setupApp function.
src/model/apps.js Removed Schema import from 'mongoose' and export of AppSchema.
test/integration/appsAPITests.js Added imports and adjusted tests for getTransformedImportMap.

🐇 In the code, new paths we chart, With URLs that play their part, Configs set and tests all primed, Docker's ready, all aligned.

A rabbit's joy in every line, For changes made, the code does shine. 🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.