search

jembi / openhim-legacy

OpenHIM is a open source Health Information Mediator built to facilitate interoperability between disparate Health Information Systems.
openhim.org
Mozilla Public License 2.0
15 stars 2 forks source link

Enable mutual TLS authentication for client of the OpenHIM #208

Closed rcrichton closed 10 years ago

rcrichton commented 10 years ago

Fixes #207 Fixes #204

rcrichton commented 10 years ago

Hey @devcritter , could you please review this? It seems to be working well but the only problem is that even if a user chooses to use mutual authentication they still have to have LDAP installed even through it isn't used. Maybe we can address this if we decide to remove LDAP storage for system user account.

rcrichton commented 10 years ago

PS, I didn't realise this would actually be so easy with Mule.

hnnesv commented 10 years ago

For issue #204, shouldn't we rather make the timeout value configurable (using 1min as a default)?

rcrichton commented 10 years ago

Yeah, true. I remember talking about that. I'l make the change.

rcrichton commented 10 years ago

@devcritter I've made the timeout configurable and also split the config for basic auth from that of mutual authentication. You can now select which one you want you want to enabled independently.

hnnesv commented 10 years ago

Cool. Yup it all looks good to me. :+1: