search

jembi / openhim-mediator-mapping

An OpenHIM mediator for mapping incoming content to a different format
https://jembi.github.io/openhim-mediator-mapping/
MIT License
3 stars 6 forks source link

OHIE-431: response bug openhim #111

Closed BMartinos closed 4 years ago

BMartinos commented 4 years ago

This PR address a bug found where error responses are not returned correctly. It returned all the chained response as part of the main response. The response of the final downstream server should be returned in the response body

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ce44787). Click here to learn what that means. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #111   +/-   ##
=========================================
  Coverage          ?   97.50%           
=========================================
  Files             ?       21           
  Lines             ?      802           
  Branches          ?        0           
=========================================
  Hits              ?      782           
  Misses            ?       20           
  Partials          ?        0
Impacted Files Coverage Δ
src/middleware/externalRequests.js 97.32% <100.00%> (ø)
src/db/models/states.js 100.00% <0.00%> (ø)
src/openhim.js 84.00% <0.00%> (ø)
src/db/services/states/index.js 100.00% <0.00%> (ø)
src/db/services/endpoints/index.js 100.00% <0.00%> (ø)
src/middleware/initiate.js 98.64% <0.00%> (ø)
src/endpointRoutes.js 100.00% <0.00%> (ø)
src/middleware/validator.js 100.00% <0.00%> (ø)
src/middleware/transformer.js 100.00% <0.00%> (ø)
src/index.js 96.15% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ce44787...ff655f8. Read the comment docs.