search

jembi / openhim-mediator-mapping

An OpenHIM mediator for mapping incoming content to a different format
https://jembi.github.io/openhim-mediator-mapping/
MIT License
3 stars 6 forks source link

OHIE-431: orchestrations bug #112

Closed BMartinos closed 4 years ago

BMartinos commented 4 years ago

This fixes a bug where orchestrations were being replaced instead of added to the existing array Using "unshift" on an array is for adding individual items to the array (comma separated), but we need to append the entire array "Concat" adds an existing array to antoher array without having to loop through each array item and then using "unshift"

https://www.w3schools.com/jsref/jsref_unshift.asp https://www.w3schools.com/jsref/jsref_concat_array.asp

Edit

Also updated the orchestration name to be a bit more descriptive. Added in a orchestration for validation middleware

codecov[bot] commented 4 years ago

Codecov Report

Merging #112 into OHIE-431-response-bug-openhim will decrease coverage by 0.31%. The diff coverage is 73.68%.

Impacted file tree graph

@@                        Coverage Diff                        @@
##           OHIE-431-response-bug-openhim     #112      +/-   ##
=================================================================
- Coverage                          97.50%   97.18%   -0.32%     
=================================================================
  Files                                 21       21              
  Lines                                802      818      +16     
=================================================================
+ Hits                                 782      795      +13     
- Misses                                20       23       +3
Impacted Files Coverage Δ
src/openhim.js 80.76% <0.00%> (-3.24%) :arrow_down:
src/middleware/validator.js 97.36% <91.66%> (-2.64%) :arrow_down:
src/middleware/externalRequests.js 97.35% <100.00%> (+0.02%) :arrow_up:
src/middleware/mapper.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ff655f8...3ef0a03. Read the comment docs.