search

jembi / openhim-mediator-mapping

An OpenHIM mediator for mapping incoming content to a different format
https://jembi.github.io/openhim-mediator-mapping/
MIT License
3 stars 6 forks source link

Ohie 519 headers data extraction feature #162

Closed bradsawadye closed 2 years ago

bradsawadye commented 2 years ago

For enabling the mapping of data in the response and request headers.

codecov[bot] commented 2 years ago

Codecov Report

Merging #162 (e743b07) into master (916e802) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head e743b07 differs from pull request most recent head 4e7160c. Consider uploading reports for the commit 4e7160c to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   97.15%   97.15%           
=======================================
  Files          21       21           
  Lines         950      950           
=======================================
  Hits          923      923           
  Misses         27       27
Impacted Files Coverage Δ
src/middleware/initiate.js 98.75% <ø> (ø)
src/middleware/externalRequests.js 98.21% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 916e802...4e7160c. Read the comment docs.

bradsawadye commented 2 years ago

@MattyJ007 i agree with that. I only did it because the new feature is a breaking change and the mappings for lookupRequests are now done differently as the response is now nested. Its to cater for those people who use the old versions of the mapping mediator. If they use the new documentation there would be failures and incorrect mappings

MattyJ007 commented 2 years ago

I think that caveat can be covered with a note in the docs rather.

The lookupRequests data structure is nested from v3 ... etc...