jembi / openhim-mediator-mapping

An OpenHIM mediator for mapping incoming content to a different format
https://jembi.github.io/openhim-mediator-mapping/
MIT License
3 stars 6 forks source link

Tb 181 fix error handling #209

Closed bradsawadye closed 8 months ago

bradsawadye commented 8 months ago

Make the error returned more descriptive and add ability to return a fhir response error from a lookup or response request (done by specifying the property fhirResponse to true in the endpoint schema

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2ddf6e5) 96.72% compared to head (02f770e) 96.75%. Report is 2 commits behind head on master.

:exclamation: Current head 02f770e differs from pull request most recent head e3847a4. Consider uploading reports for the commit e3847a4 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #209 +/- ## ========================================== + Coverage 96.72% 96.75% +0.03% ========================================== Files 23 23 Lines 1068 1078 +10 ========================================== + Hits 1033 1043 +10 Misses 35 35 ``` | [Files](https://app.codecov.io/gh/jembi/openhim-mediator-mapping/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jembi) | Coverage Δ | | |---|---|---| | [src/constants.js](https://app.codecov.io/gh/jembi/openhim-mediator-mapping/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jembi#diff-c3JjL2NvbnN0YW50cy5qcw==) | `100.00% <100.00%> (ø)` | | | [src/db/models/endpoints.js](https://app.codecov.io/gh/jembi/openhim-mediator-mapping/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jembi#diff-c3JjL2RiL21vZGVscy9lbmRwb2ludHMuanM=) | `100.00% <ø> (ø)` | | | [src/middleware/externalRequests.js](https://app.codecov.io/gh/jembi/openhim-mediator-mapping/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jembi#diff-c3JjL21pZGRsZXdhcmUvZXh0ZXJuYWxSZXF1ZXN0cy5qcw==) | `97.90% <100.00%> (+0.02%)` | :arrow_up: | | [src/middleware/parser.js](https://app.codecov.io/gh/jembi/openhim-mediator-mapping/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jembi#diff-c3JjL21pZGRsZXdhcmUvcGFyc2VyLmpz) | `100.00% <100.00%> (ø)` | | | [src/util.js](https://app.codecov.io/gh/jembi/openhim-mediator-mapping/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jembi#diff-c3JjL3V0aWwuanM=) | `90.16% <100.00%> (+0.69%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.