search

jembi / openhim-mediator-mapping

An OpenHIM mediator for mapping incoming content to a different format
https://jembi.github.io/openhim-mediator-mapping/
MIT License
3 stars 7 forks source link

fix the hanging on create and update endpoints #71

Closed bradsawadye closed 4 years ago

bradsawadye commented 4 years ago

The endpoints for creating and updating an endpoint were hanging when a request body was not supplied. Logic to fix the hanging has been added in this commit

OHM-1013

codecov[bot] commented 4 years ago

Codecov Report

Merging #71 into master will increase coverage by 0.27%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   85.67%   85.95%   +0.27%     
==========================================
  Files          22       22              
  Lines         768      776       +8     
==========================================
+ Hits          658      667       +9     
+ Misses        110      109       -1
Impacted Files Coverage Δ
src/endpointRoutes.js 30.70% <100.00%> (+5.23%) :arrow_up:
src/db/services/endpoints/cache.js 80.76% <0.00%> (+3.84%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2c72721...c3887b8. Read the comment docs.

BMartinos commented 4 years ago

Thanks @bradsawadye this fixes the bug :+1: There are a few lines in the external requests tests this currently isnt covered. Im not sure if this is addressed somewhere else maybe?