search

jembi / openhim-mediator-mapping

An OpenHIM mediator for mapping incoming content to a different format
https://jembi.github.io/openhim-mediator-mapping/
MIT License
3 stars 6 forks source link

OHM-1002 clean up #74

Closed MattyJ007 closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #74 into master will increase coverage by 12.67%. The diff coverage is 97.72%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #74       +/-   ##
===========================================
+ Coverage   85.82%   98.50%   +12.67%     
===========================================
  Files          22       21        -1     
  Lines         776      734       -42     
===========================================
+ Hits          666      723       +57     
+ Misses        110       11       -99
Impacted Files Coverage Δ
src/db/services/endpoints/cache.js 92.30% <75.00%> (+15.38%) :arrow_up:
src/db/services/endpoints/index.js 100.00% <100.00%> (+7.14%) :arrow_up:
src/endpointRoutes.js 100.00% <100.00%> (+69.29%) :arrow_up:
src/middleware/externalRequests.js 98.17% <100.00%> (ø)
src/openhim.js 92.85% <100.00%> (+19.04%) :arrow_up:
tests/utils.js

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7021b80...5d57d81. Read the comment docs.

bradsawadye commented 4 years ago

@MattyJ007 looks all good, just a few comments for you to address