search

jembi / rhea-shr-adapter

RHEA SHR Adapter
Mozilla Public License 2.0
0 stars 2 forks source link

Fix errors in RHEA SHR Patient creation #40

Closed surangak closed 10 years ago

surangak commented 10 years ago

The following errors were detected in the SHR Adapter module during OHIE sandbox testing.

1) The patients' first name and family name were interchanged 2) When creating new patients on the SHR, the gender may be set to N/A even in instances where it was present (this fix became necessary after patient gender was added to the ORUR01 messages sent from the IOL to the SHR) 3) Due to a problem with the parsing of the patient birthdate, birthdates falling on the 1st of the month may be represented incorrectly in the SHR DB.

I will make the changes required to fix this, and submit them here. A separate script will be created to update existing RHIE SHR db records with correct values.

surangak commented 10 years ago

See fixes in pull request at : https://github.com/jembi/rhea-shr-adapter/pull/41

(PS: Looking back at this code, I cant help wonder, what on earth was I thinking when I wrote this an year ago (??)

hnnesv commented 10 years ago

Thanks for this Suranga!

Luckily the patient demographic data always gets pulled from the CR, so the impact isn't too high. In fact ideally we shouldn't be storing any demographics data at SHR level, but I know that's not an option atm in OMRS.

cc @waynechelliah @rcrichton

hnnesv commented 10 years ago

The code as is used in Rwanda has been tagged at (https://github.com/jembi/rhea-shr-adapter/releases/tag/1.0-RW), so we can easily identify the point at which these new changes came in. However we'll need to align this project with the current Jembi Github flow moving forward.

surangak commented 10 years ago

Thank you Hannes.

Yikes, I didn't realize that we had an RW tag for the poc module. Do we have a list of changes between this tag and the master ?

On Fri, Dec 6, 2013 at 5:45 AM, Hannes Venter notifications@github.comwrote:

The code as is used in Rwanda has been tagged at ( https://github.com/jembi/rhea-shr-adapter/releases/tag/1.0-RW), so we can easily identify the point at which these new changes came in. However we'll need to align this project with the current Jembi Github flow moving forward.

— Reply to this email directly or view it on GitHubhttps://github.com/jembi/rhea-shr-adapter/issues/40#issuecomment-29978996 .

Best Regards,

Suranga

hnnesv commented 10 years ago

I made the tag just before merging these changes; so the changelist is therefore just this issue currently.

rcrichton commented 10 years ago

Thanks for taking this forward Hannes, good idea on the tag.

Yeah ideally we shouldn't need any demographics but I don't think you can do that in OpenMRS. So it is ok for now. (we are also moving towards a new SHR so I don't think it need to be changed).

Suranga, thanks for working on some code to get these issues fixed. We need all the help we can get! Particularly because RHIE has less development focus and more implementation focus now days.