Closed amclain closed 8 years ago
Thanks for the PR.
Regarding the failure you saw locally - I think it might be the case that different versions of RabbitMQ raise different errors for that condition. Which would mean that this test isn't valid for all versions of RabbitMQ, so I should either remove the test or take the time to set up a rake task to set up a specific version of RabbitMQ in a docker container, available for testing. This latter would probably be the better option.
It looks like the CI failure is unrelated to either this PR or the outstanding issue you had (it's missing the right version of rake
, and needs a bundle install
thrown in somewhere).
This PR adds the
DEFAULT_EXCHANGE
andAVAILABILITY_ERRORS
constants we discussed.Just FYI, this test was failing on
master
before I started the work, and is still failing: