search

jemgold / figma-js

Little wrapper (+ types) for the Figma API
https://jongold.github.io/figma-js/
MIT License
491 stars 47 forks source link

Upgrade Types #15

Closed chrisdrackett closed 5 years ago

chrisdrackett commented 5 years ago

Based on the current API Figma returns

chrisdrackett commented 5 years ago

@jongold curious what your thought are on getting this merged and published? the package I'm working on that uses these types is waiting on it :D

jemgold commented 5 years ago

Shoot, didn't realize I hadn't published! My bad, will do that by tomorrow at the latest :)

On Thu, May 16, 2019, 4:55 PM Chris Drackett notifications@github.com wrote:

@jongold https://github.com/jongold curious what your thought are on getting this merged and published? the package I'm working on that uses these types is waiting on it :D

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jongold/figma-js/pull/15?email_source=notifications&email_token=AAEQOG3NKTSPFUS4K6ZM7X3PVXX77A5CNFSM4G6S5VH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVTLHYY#issuecomment-493269987, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEQOG2LUHRH6JE7MISDETLPVXX77ANCNFSM4G6S5VHQ .

jemgold commented 5 years ago

@chrisdrackett can you try 1.7.0? 🙏

chrisdrackett commented 5 years ago

@jongold looks good, type errors gone :) thanks!

I'll keep working on this as I go, I'm finding the Figma API docs don't align 100% with what the json actually returns. I'm guessing there are other things I'm missing