add params `version` and `geometry` to GET:file

jemgold / figma-js

Little wrapper (+ types) for the Figma API

https://jongold.github.io/figma-js/

MIT License

490 stars 47 forks source link

Closed g-a-v-i-n closed 6 years ago

g-a-v-i-n commented 6 years ago

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Feature: Update GET:file endpoint
What is the current behavior? (You can also link to an open issue here) GET:file has no parameter argument
What is the new behavior (if this is a feature change)? Adds a parameters argument to GET:file, which can accept version and geometry params.
Other information:

jemgold commented 6 years ago

rad, thanks! thoughts on making params optional so it doesn't break existing uses?

readonly file: (
  fileId: string,
  params?: FileParams
) => AxiosPromise<Figma.FileResponse>

g-a-v-i-n commented 6 years ago

Oh, that should definitely be implemented. First time using TS over here.

jemgold commented 6 years ago

I can merge and fix it before publishing :) Also going to add types for the things that get added when you use geometry