search

jemiahlee / ATwitter

iOS twitter app
0 stars 0 forks source link

Submission homework #3 #1

Open jemiahlee opened 8 years ago

jemiahlee commented 8 years ago

/review @codepathreview

Had some issues with making my .gif, and some of the operations which I think should be synchronous aren't, which cause a few glitches in the updating of fields/images.

jemiahlee commented 8 years ago

This is the submission hash/tree: https://github.com/jemiahlee/ATwitter/tree/caa58ae400d91bb45e0c434075de46b6829b77ae

I'm fixing a few things this morning.

codepathreview commented 8 years ago

:+1: nice work. With this assignment, we've now explored all the main patterns for building MVC clients! If this were 2009, you would be well on your way to building most apps that you could find in the app store. Over the next few weeks, we'll be focusing on custom views and view controllers to implement the interactions and visual effects that we find in more modern iOS apps.

A small comment is that you shouldn't create another segue to back from the CreateTweetViewController to TweetsViewController. You should use popToRootViewControllerAnimated or popToViewController instead. You can visit this page to get more information about the UINavigationController.

We have a detailed Project 3 Feedback Guide which covers the best practices for implementing this assignment. Read through the feedback guide point-by-point to determine ways you might be able to improve your submission. You should consider going back and implementing these improvements as well. Keep in mind that one of the most important parts of iOS development is learning the correct patterns and conventions.

If you have any particular questions about the assignment or the feedback, feel free to reply here or email us at support@codepath.com

This was a very challenging assignment, congrats on completing it successfully!