search

jeminsieow / pe

0 stars 0 forks source link

Able to add instructors that don't exist #6

Open jeminsieow opened 4 years ago

jeminsieow commented 4 years ago

Went into json file and changed instructor

image.png

It shows in the app, although this instructor does not exist

image.png

nus-se-bot commented 4 years ago

Team's Response

Thank you for your report! Using the same instruction from the website, though, fixing the instructor validation is not “essential for the app to be reasonably useful”. This is because regular users would use the application without tampering with the .json file at all, and thus no non-existent instructors would ever appear in any modules.

Even if this is a problem, the severity should be low as it only happens very rarely (a regular user should not tamper with the .json file).

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: This is one of the constraints of the tp. Advanced users should be able to tamper with the files, therefore this bug is valid.

image.png

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]