jemishgopani / wdio-json-reporter

A WebdriverIO plugin. Report results in json format. http://webdriver.io
13 stars 32 forks source link

Merge results - function arguments as input parameters #30

Closed kmnaid closed 4 years ago

kmnaid commented 5 years ago

The function mergeResults takes arguments as input which are not used by it. It uses the process arguments - process.argv[2] and process.argv[3] to set the directory and file pattern. This function is called from other scripts that could have different process arguments set and hence does not work for this case. Can mergeResults instead use the arguments sent to it to get the directory and file pattern?

kmnaid commented 5 years ago

@fijijavis : Do you think this could be changed?

fijijavis commented 5 years ago

@kmnaid yes. I thought there was an open PR but I can’t find it now???

kmnaid commented 5 years ago

@fijijavis : Oh I see, I can create one.

fijijavis commented 4 years ago

PR #42 resolves the issue