search

jemmybutton / byrne-euclid

MetaPost + TeX rendition of Oliver Byrne's "The first six books of the Elements of Euclid"
GNU General Public License v3.0
1.2k stars 105 forks source link

[Nit] Consider using upright parentheses in italic text #10

Closed MarcinCiura closed 1 month ago

MarcinCiura commented 7 years ago

Hi, Sergey. Byrne uses upright parentheses in propositions. Bringhurst's Elements of Typographic Style also recommend them. Caveat: I am not sure what to do when the closing parenthesis is followed by another punctuation mark like the colon in proposition IV of book I.

jemmybutton commented 7 years ago

Hi, Mciura. I agree with you, upright parentheses look better. The solutions you provide link to seem to be LaTeX specific, it will take some time to figure out how to do it properly in ConTeXt.

jemmybutton commented 5 years ago

@mciura Hi, Marcin. Better late than never: this https://github.com/jemmybutton/byrne-euclid/commit/6bb880ed70b43c1148eac75bb9c805ee4f1539b4#diff-acb525a5a0669b6175601decd8757cf1R18 seems to turn parentheses in italics upright. Basically, it's a fallback, which forces parenthesis from "roman" into "italic", but it seems not to break anything and look ok. parentheses

MarcinCiura commented 5 years ago

A possible alternative is to use math parentheses. Their disadvantage is no line breaks between \left( and \right) unless you break the equation and use \vphantom or substitute \Big etc. for \left and \right. parens

jemmybutton commented 5 years ago

@mciura Also math parentheses won't be very convenient when it comes to text. I'll try to find a way to change metrics for these two characters (parentheses) in italics in order for them to look as of they respect italics correction. Or maybe adopt some other solution.

jemmybutton commented 5 years ago

@mciura This seems to be a working solution.

jemmybutton commented 5 years ago

@mciura Adding this line https://github.com/jemmybutton/byrne-euclid/commit/aecd132808870799d7615ebedb2841b71ef5add2#diff-ce29b5befc0686b45157d97a74d17263R20 fixes this problem. Although i don't understand yet why it works.