jemmybutton / byrne-euclid

MetaPost + TeX rendition of Oliver Byrne's "The first six books of the Elements of Euclid"
GNU General Public License v3.0
1.19k stars 104 forks source link

[Nit] Consider changing the shade of yellow and possibly blue #9

Open MarcinCiura opened 6 years ago

MarcinCiura commented 6 years ago

Hi Sergey. I am merely relaying a Reddit comment about the shades of yellow and blue in your book. Although I tend to agree with /u/jacobolus that the yellow might be warmer, this is a matter of taste so the ultimate call is yours. As a side note, I checked your colours against deuteranopia, protanopia, and tritanopia with Vischeck. The good news is that all colorblind people can distinguish its colors. Here is how a deuteranope sees it: deuteranope

jemmybutton commented 6 years ago

Hi Mciura. The colours are currently more like placeholders for colours to be. Simply picking them from the scanned Byrne's original didn't work for me (because, for example, blue is too dark and is easily confused with black), so I just defined them to be dissimilar enough to be easily identified during proof-reading. Otherwise, I agree and have changed them a little, to look nicer (hopefully). Thank for the link to Vischeck! byrne_context.pdf I am not closing this issue yet, because my laptop screen may not be the best to judge colours.

MarcinCiura commented 6 years ago

Don't you need to change these color definitions, too?

jemmybutton commented 6 years ago

You're right, I just forgot about this (fixed). These definitions only affect coloured letters in the fifth book. It's actually possible to define metapost colors from ConTeXt, but I didn't do it because I thought it would be better to make mp code more or less independent from ConTeXt code, but maybe it doesn't matter any more.

jrus commented 6 years ago

I’m just eyeballing the Taschen book (in which colors vary a bit, and I’m going for something probably a bit more colorful than the average there), but let me recommend the sRGB colors:

red: d84737 yellow: eeb131 blue: 025e97 black: 342920

(background: fefbeb)

At least for screen display. For printing you probably want to specify something CMYK.

euclid-colors

For helping the color-blind (and everyone else for that matter) the most important feature is lightness contrast. The colors I’m recommending here have lightness L* = {76, 52, 38, 18}, respectively.


Your updated choices are also fine though.

For comparison: your new colors:

euclid--colors-copy-2

your old colors:

euclid--colors-copy

jemmybutton commented 6 years ago

Hi, Jacob. Thank you! I've changed the colours a little, they are now much closer to yours, probably. But I still like blue to be a little bit lighter (sometimes it looks too close to black in Byrne's book for me). I suspect that it's not just difference in lightness that matters, but difference in lightness between colours relative to difference in lightness between them and the background, i. e. darker colours look more similar against lighter backgrounds than against darker ones, other things being equal. I've also added a new colour for black (called byblack) and it is used throughout the book, and even though it is now equal to regular black, it is easy to change it to some sort of dark grey without messing with the definition of black. I'll leave the background white for now, but will consider changing it when I'll have better understanding of how the book can actually be used. See here byrne_context.pdf