search

jemproject / JEM-Project

JEM - an Event Manager for Joomla
https://www.joomlaeventmanager.net
GNU General Public License v3.0
27 stars 39 forks source link

Unite countries.php and #__jem_countries table #1134

Open Hoffi1 opened 7 years ago

Hoffi1 commented 7 years ago

Actually we have a table #__jem_countries but also a class JemHelperCountries (in (site)/herlpers/countries.php) - both with e.g. the country name. Models like eventslist and search get information from the table but others seem to get if from class.

This incubator of inconsistency should be replaced by a single source. I would suggest to keep the table as master and let the helper class provide additional functionality using the table.

jojo12 commented 7 years ago

Perhaps together with that: there is a key NO_VALID_COUNTRY which is not possible to translate (I tried with language override) looks not so nice.