jemproject / JEM-Project

JEM - an Event Manager for Joomla
https://www.joomlaeventmanager.net
GNU General Public License v3.0
27 stars 39 forks source link

Strange comportment: when there is a venuecalendar #1538

Open jojo12 opened 1 year ago

jojo12 commented 1 year ago

When I have a venue calendar and I click in eventlist or event detail on the venue link of a venue, I normally should reach the venue detail of this venue. But I only reach the venue calendar of the clicked venue (even when I don't have a menue for this venue!)

mckillo commented 1 year ago

I don't see the issue, could you indicate more details or capture view?

jojo12 commented 1 year ago

capture isn't possible, I can't capture a switch! To reproduce (in jem4test.joomla.com) I created a menue item: "Lokalkalender" for Pétanque-Platz Kalkhof. This works! Then I go to "Agenda"= Simplelist and click on the link of a venue. Without "venue calendar" I get the detail view of venue. (like set in JEM settings) But now I get a venue calendar of the clicked venue.

jojo12 commented 1 year ago

When I disable the menue item "Lokalkalender", then the link is correct to the venue details view!

mckillo commented 1 year ago

In this case, in a issue of Joomla but It depends of the menu active created. When Joomla creates your page for the menu Agenda, there are a lot link, for each one, Joomla check if the link exits in a active menu (in your JL).

In this eventlist view, the venue link are of this type: 'index.php?option=com_jem&view=venue&id=1:name_place'

If venue link exists, \components\com_jem\helpers\route.php - getVenueRoute($id) call to Joomla, Joomla will find any link of menu with the type of option and view, and if it exists, change your link to frienly links (alias menu).

You have this error becuase JEM don't find any menu for: option=com_jem&view=venue&id=1 option=com_jem&view=venues&id=1 but if it found a link to menu: option=com_jem&view=venue (You have one of this type: option=com_jem&view=venue&layout....) --> Check it: See URI od this URL https://jem4test.joomla.com/index.php/lokalkalender Take the alias menu and change it.

Solution: Create a unpublish menu of type: JEM venues and you'll have the right link for each venue in Agenda page.

mckillo commented 1 year ago

When I said, unpublish menu, is a active menu into group menu (no main menu, other) no visible as module.

jojo12 commented 1 year ago

Wow! You're so excellent! But it's good to know that. I didn't know

mckillo commented 1 year ago

In my opinioin, it's a issue of design, when use layout into view. Joomla check typically URL with &option and &view attributes, but if there is any menu with same attribute + &layout, Joomla does not detect it.

mckillo commented 1 year ago

Workaround is a no visible menu for venues and categories. :- )

mckillo commented 1 year ago

In current version, this is as Joomla is working and as JEM was designed. Solution from JEM: review JEM structure, it'll convert calendar layout in views as pure views

Heklaterriol commented 1 year ago

What should we do with this?

jojo12 commented 1 year ago

I think, this should be mentioned somewhere. When I know it, then there's a way to prevent, but this needs an action of the admin

mckillo commented 1 month ago

I think that this issue could be closed or left open if we want to convert the layouts to views. What do we do?