jemproject / JEM-Project

JEM - an Event Manager for Joomla
https://www.joomlaeventmanager.net
GNU General Public License v3.0
25 stars 37 forks source link

min PHP version check #1566

Closed Heklaterriol closed 1 year ago

Heklaterriol commented 1 year ago

Just found in script.php on line 220-227:


    // Minimum required PHP version
        $minPhpVersion = "5.3.1";

        // Abort if PHP release is older than required version
        if(version_compare(PHP_VERSION, $minPhpVersion, '<')) {
            Jerror::raiseWarning(100, JText::sprintf('COM_JEM_PREFLIGHT_WRONG_PHP_VERSION', $minPhpVersion, PHP_VERSION));
            return false;
        }

Should be $minPhpVersion = "8.0";, right?

mckillo commented 1 year ago

It's fine In the JEM-for_Joomla-4/script.php:239 $minPhpVersion = "8.0.0"; In he JEM-Project\package\pkg_install.php is fine too.. I only see this in JEM 2.3.6 (master branch, in this case it's right). Where do you see $minPhpVersion = "5.3.1"?

Heklaterriol commented 1 year ago

Ops, I think I was in the wrong branch :-(