jemproject / JEM-Project

JEM - an Event Manager for Joomla
https://www.joomlaeventmanager.net
GNU General Public License v3.0
25 stars 37 forks source link

cancel tickets: strange reaction! #1593

Closed jojo12 closed 1 year ago

jojo12 commented 1 year ago

grafik I have booked 3 places. Now I try to cancel. the error is: the add places button shows me a modal window and refuses my canceling!

jojo12 commented 1 year ago

needs more testing! unlogic comportment!

jojo12 commented 1 year ago

fix above (2469a38) is only in legacy, there it's fixed.

next issue: (when min/user=1 max/user=1 Problem: WAITINGLIST if waitinglist=yes --> when attending after canceling, then user is only on waitinglist, but should be on attendinglist. if waitinglist=no --> when attending after canceling, then user is on attendinglist! This is ok!

(when min/user=1 max/user=2) if waitinglist=yes --> when attending, but booking additional place, then user and new place is on waitinglist, but should be on attendinglist if waitinglist=no --> when attending, but booking additional place, then user and new place is on attendinglist. This is ok

(waitinglist should only be used, if there's not enough place on attendinglist /or if admin decides to put a user on waitinglist)

jojo12 commented 1 year ago

next issue: the button "Register" should be renamed, because we use it for registering and unregistering for events. my proposal "Send"

jojo12 commented 1 year ago

next issue: in editevent I invite a user. It's possible to invite him with 0 or 1 place. But 0 place doesn't make sense! invitation with frontend>attendee manager works fine. Inviting is possible until the max/user

mckillo commented 1 year ago

Fixed in default too.

I have to study the waiting list (simulate case)... let's me test it.

jojo12 commented 1 year ago

waitinglist seems to be the problem only when max.user=0

jojo12 commented 1 year ago

fixed in responsive too (32fe7f5)

mckillo commented 1 year ago

I don't see the error, for me the register book places or book waiting places are working. See image with example.

JEM4 -book places or book waiting places are fine

How you see, I have changed the register buttom too.

mckillo commented 1 year ago

Ok, I had not refreshed the issue page, and I just saw that it is when max.user=0. Let's me test it again.

mckillo commented 1 year ago

But, It hasn't sense to have a waiting list when the Max.Places is 0. Waiting list value should be ignored when Max. places is 0.

mckillo commented 1 year ago

If Max.places is 0, waiting lislt should be disable or save as disable.

jojo12 commented 1 year ago

It's after the last step you made. When you try to attend again! then you're only on the waitinglist!

mckillo commented 1 year ago

But any user should be on a waiting list if Max. Places is 0. If it succeeds because the admin have changed the registration setting of the event (with users registrated and in waiting list), right?

jojo12 commented 1 year ago

No: we said: max. places is: there's no limit of participants!

mckillo commented 1 year ago

Yes, if max.places is 0, the number of places for event is unlimited and for this reason, waiting list should be empty.

JEM4 - There is a waiting list because max_places is defined is greater than 0 and the booked places is same number

mckillo commented 1 year ago

I think that I understand you. Now, if the admin change to Max.places =0 in the event, the user C doesn't change to booked places and only can cancel, but it's normal.

When the user registers a places, the status of this places doesn't change.

The admin should change all users in the waiting list to attendees (manual by admin or wait to next registration, the plugin should change it with the new status).

If user with booked places on the waiting list wants to change to booked places, first the user has to cancel the waiting places and after that he can book the max. booked places.

mckillo commented 1 year ago

I think that I simulate the case....

jojo12 commented 1 year ago

grafik

jojo12 commented 1 year ago

the settings were not changed: grafik

mckillo commented 1 year ago

@jojo12 Fixed. Check it (see commit above)

jojo12 commented 1 year ago

error: Unmatched ')' in responsive

mckillo commented 1 year ago

Sorry, Ctrl+V didn't work.... Solved. See las commit above

jojo12 commented 1 year ago

yes, it works, thanks I continue to test!