jemproject / JEM-Project

JEM - an Event Manager for Joomla
https://www.joomlaeventmanager.net
GNU General Public License v3.0
25 stars 37 forks source link

request answer: adding info for event registration? #1599

Closed jojo12 closed 1 year ago

jojo12 commented 1 year ago

Something is not very clear in the event registration: in different groups it will be used differently! 1) e.g. booking a ticket for an event, then you don't need to say, that you will not come. Only for canceling a booked ticket. 2) e.g. in a group, it can be essential to say, that you can't come. So it needs an answer! both things are possible with our system, but is this clear for admins and users?

Do we have to add a phrase for this?

mckillo commented 1 year ago

I see two things:

  1. When the min.places=max.places=1 don't show option to add new places.
  2. In the setting regitration of event, new check for request response assistance. In the first registration, don't show the ' I will NOT go to this event" if cnew check is unmark.

See the proposal in the following image:

JEM4 - Proposal for improvement of registration information in event

What do you think?

jojo12 commented 1 year ago

Good proposal

mckillo commented 1 year ago

Here you are. First step of the proposal. First step to proposal. New 'Request answer asssistence" in setting event, if enabled, show option to the user doesn't go the event.

jojo12 commented 1 year ago

I installed the com_jem.zip made from request-answer. I see in backend the events and in it the new button, but in frontend and modules all events are away!

mckillo commented 1 year ago

if Request answer asssistence is uncheck, first time when the user go to the event, in your registration option, doesn't show the 'I will not go to this event' option. Right?

jojo12 commented 1 year ago

I will test

jojo12 commented 1 year ago

I can't see any event details because, all events are not visible in frontend, when request-answer is installed. I can only see the button field "request answer assistance", i can check it or uncheck it, nothing more.

jojo12 commented 1 year ago

I created in backend a new event with only category, title and date, then when I go to "My attendances" I get 1054 Unknown column 'a.requestanswer' in 'field list', same in "My events"

mckillo commented 1 year ago

Your package should have \admin\sql\updates\mysql\4.0rc1.sql, but I don't know why don't run it.

Run this script sql (change #_ for your prefix database): ALTER TABLE#__jem_eventsADDrequestanswerTINYINT(1) NOT NULL DEFAULT '0' AFTERwaitinglist;

And tell me, if the error is solved.

jojo12 commented 1 year ago

when I use this ALTER TABLE #__jem_eventsADDrequestanswerTINYINT(1) NOT NULL DEFAULT '0' AFTERwaitinglist; i get#1064 - Fehler in der SQL-Syntax. Bitte die korrekte Syntax im Handbuch nachschlagen bei '' in Zeile 1

mckillo commented 1 year ago

You have to change #_ for your prefix xxxxx , all you Joomla tableshave a prefix, use your prefix. For example for me: ALTER TABLE a8wlc_jem_events ADD requestanswer TINYINT(1) NOT NULL DEFAULT '0' AFTER waitinglist;

jojo12 commented 1 year ago

even when I do that, I get: #1064 - Fehler in der SQL-Syntax. Bitte die korrekte Syntax im Handbuch nachschlagen bei 'ALTER TABLE jos_jem_events ADD requestanswer TINYINT(1) NOT NULL DEFAULT '0' ...'

mckillo commented 1 year ago

The sentence is right: ALTER TABLE a8wlc_jem_events ADD requestanswer TINYINT(1) NOT NULL DEFAULT '0' AFTER waitinglist; I don't have any error.

Do you have requestanswer filed int _jem_events table?

Testeing with INT: ALTER TABLE a8wlc_jem_events ADD requestanswer1 INT NOT NULL DEFAULT '0' AFTER waitinglist; Remember to change the prefix.

jojo12 commented 1 year ago

Now I uninstalled the whole JEM with cleanup and installed a jem package from branch regquest-answer. But there's no event and I can't install samplecode it's says: not empty, but there's nothing in

mckillo commented 1 year ago

In the beginig, I told you that there is a root category and the this tables isn't empty, you told me that root category must be. I use housekeeping - Delete all data and solved.

jojo12 commented 1 year ago

i get this: grafik

mckillo commented 1 year ago

@jojo12 Delete line 180 with?> in \components\com_jem\views\event\tmpl\responsive\default_regform.php file

mckillo commented 1 year ago

Finish the proposal with last commit (see above), If max.bookedp places per user =1, don't show "I want to book 1 places", by default is 1 (user).

jojo12 commented 1 year ago

Actually I can't test the second part. The first part works fine in responsive and legacy now. Before I had problems to add the additional field in db. I had to extract directly from the sql/update folder to succeed. I tested on a xampp, but I had the "Call to a member function format() on bool" again in frontend

mckillo commented 1 year ago

I try to see this error, but I don't find it.

JEM4 - Proposal string in the registration

jojo12 commented 1 year ago

1) I see the problem! no entry in DB xxxxx_jem_register = gave no answer entry in DB xxxxx_jem_register = gave an answer AND field status = 0 =is invited but gave no answer AND field status = 1 =gave an answer, will participate (IF waiting = 0 is on attendeelist) (IF waiting =1 is on waitinglist) AND field status =-1 =gave an answer, will NOT participate

jojo12 commented 1 year ago

2) as admin in attendee manager I can add a user with 0 places, (even if the min/user is 1)

jojo12 commented 1 year ago

3) text for button is better to have it always as "Send" Don't switch between "send" and "register"! "Send" can be used for "register" and "unregister"

jojo12 commented 1 year ago

Only thinking: when the user is forced to give an answer (min/user=1 and max/user=1 and the button), it should always be possible to say: NO, I can't.

mckillo commented 1 year ago

I don"t know when but I will try to simulate it.

jojo12 commented 1 year ago

I am thinking loud: If someone has not yet answered, he has no entry. The procedure saying NO, seems to look if there is an entry, and because there is not yet an entry, it fails. (If somebody said YES, then there is an entry. When then someone says NO, the procedure finds an entry and changes it. This works) -->If someone answers NO, the procedure should create an entry with the answer NO. EDIT: If a user is invited, there's an entry, so the procedure find it, and the NO works.

jojo12 commented 1 year ago

[@mckillo: Hi, I am back from holydays, will continue]

jojo12 commented 1 year ago

I don't find the place in the program where is "COM_JEM_ERROR_REGISTRATION", which comes after a user says "I will not come" EDIT: site/models/event.php line 643 line 723

jojo12 commented 1 year ago

If a user says directly NO, then the program has to make an entry in DB jem_register with status=-1 (this should be like on an other place the first entry, when someone is invited then the program makes an entry in DB jem_register with status=0)

jojo12 commented 1 year ago

Perhaps it is easier, only to add a sentence like "In any case, we need your answer"! (But this doesn't solve the problem, that unregistration is only possible, when registrated or at least invited before.) If someone feedbacks directly NO, then we get the error.

jojo12 commented 1 year ago

[Actually you first has to say YES, to say after NO -> to get the wanted result]

mckillo commented 1 year ago

I'm sorry, but I thought you knew that the request-answer branch wasn't include in the release 4.0.0 and neither in the 4.0.1dev, but you demand is this feature that I was upload to the branch the 3th july. See the image below in https://github.com/jemproject/JEM-Project/issues/1599#issuecomment-1618671719 Have you tested it? (If not, when you have any time). If it's good, I can added to 4.0.1dev

jojo12 commented 1 year ago

the problem, directly to say NO, I can't come is in 4.0.0 and in your request answer branch (came from book tickets) . Because the book tickets is committed in 4.0.0 (since 4.0rc1) the problem exists in both (4.0.0 and request answer)

mckillo commented 1 year ago

Yes, I know, but this branch is a solution (patch/enhancement). Are you agreement with the image below and the new option in registration setting? Perhaps, it may be that I am not understanding the statement of the problem correctly and I am approaching it in another way.

jojo12 commented 1 year ago

where is an image?

mckillo commented 1 year ago

image

mckillo commented 1 year ago

If the new options (Request answer assitence) isn't check, the user haven't 'No' option in the registration form.

jojo12 commented 1 year ago

yes, but this are two different problems. this here is trying a solution to request answer. but there is an other problem which is just in 4.0.0

mckillo commented 1 year ago

Explain me please to clarify me (Review the issues entries again).

jojo12 commented 1 year ago

Issue #1573 and #1625 are just inside of JEM 4.0.0+ and have to be solved. This is a priority! Issue #1599 is good, but has a problem inside this branch "request answer"

jojo12 commented 1 year ago

Did you understand?

mckillo commented 1 year ago

Yes, do you have the commit with solution at the end of issue #1626

Can we do a merge the 'request-answer' branch as new feature of v.4.0.1?

jojo12 commented 1 year ago

at the moment I have only this possibility: grafik

jojo12 commented 1 year ago

when this is solved then it is ok. (the other blockers are fine away!)

mckillo commented 1 year ago

Yes, now it's solved if I'll merge the branch. ok?

jojo12 commented 1 year ago

for the above image: grafik

jojo12 commented 1 year ago

in both cases DB requestanswer=0 and requestanswer=1 there is "no I will NOT go"

mckillo commented 1 year ago

Let's review and debug, because I did merge and update and unify the branchs, and it possibel to overwrite anything.

jojo12 commented 1 year ago

I made a package with your commit and tested, now it is ok! The only thing now is the request answer in legacy frontend edit #1627