search

jemproject / JEM-Project

JEM - an Event Manager for Joomla
https://www.joomlaeventmanager.net
GNU General Public License v3.0
25 stars 37 forks source link

there's a lightbox2 #1614

Closed jojo12 closed 1 year ago

jojo12 commented 1 year ago

https://github.com/lokesh/lightbox2

mckillo commented 1 year ago

With BT5 is easy, there are a lot example. See example https://trvswgnr.github.io/bs5-lightbox/

<a href="https://unsplash.it/1200/768.jpg?image=250" data-toggle="lightbox" data-caption="This describes the image">
    <img src="https://unsplash.it/600.jpg?image=250" class="img-fluid">
</a>
Heklaterriol commented 1 year ago

I had some time today and tried to build the lightbox unctionality without loading another JS library, just using Joomla 4 native elements.

Please have a look at the branch here: https://github.com/jemproject/JEM-Project/tree/lightbox (including a test installation package.)

As I'm not a real coder (just some kind of hobby) please do not hesitate to improve my code.

Heklaterriol commented 1 year ago

And I noticed that in the image settings the label "Enable Thumbnail" is not clear. When activated, the thumbnail images has a link to the full size image as a pop up. So I changed the label to "Enable Pop Up Thumbnail".

Heklaterriol commented 1 year ago

Did anybody test this? Are you ok with this solution or do you want a more sophisticated one?

I added an version based on JEM 4.0.0 (the first one ist based on JEM 4.0.1-dev1)

Heklaterriol commented 1 year ago

the modified files (compared with JEM 4.0.0)

mods fo lb

jojo12 commented 1 year ago

Sorry, I am on the road and can not test!

Heklaterriol commented 1 year ago

I just noticed that the modules wide, banner and jubilee also have modal functionalities, which do not work. I will check it out.

(By the way: In English the event images in the modules are called "flyer" – is this the correct word?)

jojo12 commented 1 year ago

I don't know, but even in component there is the word "flyer"!

Heklaterriol commented 1 year ago

After looking at the modals in the modules, I think of redoing the lightbox function with Jojos lightbox2 https://github.com/lokesh/lightbox2 Will be easier to apply to all instances of modal images.

The bootstrap version looks good too, but loads a lot of css an js, lightbox2 is much smaller.

Any opinions?

Heklaterriol commented 1 year ago

I added the lightbox2 functionality to the teaser module, the categories view and the venues view. I hope I've got all now, right? See: https://github.com/jemproject/JEM-Project/tree/lightbox2

jojo12 commented 1 year ago

I tested in merged package. Super!