jemproject / JEM-Project

JEM - an Event Manager for Joomla
https://www.joomlaeventmanager.net
GNU General Public License v3.0
25 stars 37 forks source link

dev3: backend delete events: strange comportment! #1643

Closed jojo12 closed 1 year ago

jojo12 commented 1 year ago

I wanted to trash 3 events. It shows me, that they are trashed, but they are still inside the published, and I can't delete them. Same, when I want to archive them, the info says, they are archived, but they are still inside the published. Same, when I want to hide them. I tested on 2 sites!

Please, test too: if this is really like this, this is a releaseblocker!

Heklaterriol commented 1 year ago

What do you mean by "inside the published"? visible in the frontend, in the event listing in the backend …

Heklaterriol commented 1 year ago

And where do you trash them, backend, frontend, and by what method: opening the event and changing the status, choosing the events in the listing and choosing the button ""unpublish", "archive", "trash" or …?

jojo12 commented 1 year ago

I am in backend>events, chooses the events I want to change and choose "Papierkorb" or "Archive" ... nothing changes! EDIT: frontend works fine!

Heklaterriol commented 1 year ago

Works fine here

https://github.com/jemproject/JEM-Project/assets/28540581/1d16e709-5f54-4cd2-b07b-152f85b432da

Or are you talking about something else?

jojo12 commented 1 year ago

I went back to your package and installed pkg_jem_v4.0.1-dev2.zip. There it is no problem. The problem must be inside of the package, I made from the jem 4.0.1-dev branch. EDIT: I made a new com_jem.zip from the branch and installed over the installed and working pkg_jem_v4.0.1-dev2.zip. The problem is back! So attention: the problem must be inside of admin part in git.

Heklaterriol commented 1 year ago

I will install and check actual state of the branch. Then compare pkg_jem_v4.0.1-dev2.zip with the actual files of the branch and see if I find the bug.

Heklaterriol commented 1 year ago

I can reproduce it with actual state of the branch.

jojo12 commented 1 year ago

Thanks!

Heklaterriol commented 1 year ago

I checked the differences beween the two versions (pkg_jem_v4.0.1-dev2 and actuel state) and it seems that the fix #1590 for "Frontend Edit event: "Call to a member function format() on bool" if you use not english (date)" is causing this problem.

That means the bug is somewhere in here: https://github.com/jemproject/JEM-Project/commit/2b5ceec2553fe472a9f6e95a9c7748d3f4721da9 https://github.com/jemproject/JEM-Project/commit/2b5ceec2553fe472a9f6e95a9c7748d3f4721da9

@mckillo: this is beyond my skills. Do you have time/capacities to check this?

jojo12 commented 1 year ago

@mckillo: I agree, it's only, if we can't debug then to decide we prefere which bug ;-). But I am sure you will succeed. But do you have the time to do this?

mckillo commented 1 year ago

Guau! This is serious bug. I don't know. I have simulate the issue, an it's important to solve it. I hope to resolveit today, I'm going to find time in the day to debug.

mckillo commented 1 year ago

Fixed. Please, this last commit needs a tester.

Heklaterriol commented 1 year ago

Thanks @mckillo I am on holidays, so not very active. I will check it when I'm home again.

mckillo commented 1 year ago

Me too, it's time to relax and family.

Heklaterriol commented 1 year ago

even if I'm on holidays: I checked it, and it works. Well done! @jojo12, when you're back please check it with your sites, where the problem of #1590 first occurred.

jojo12 commented 1 year ago

Hi holidayers :-) I am back and try to understand and test the history between 13 and 20 of August. I checked the branch of mckillo's commit. It works, I tested on backend (and frontend). (But in this branch, it seems, Marcos just integraded his solution with original bigger images for event details view. And with this I am not yet happy. Better to let it as it was - with flyer2 for overrides - this doesn't hurry!) The actual issue here is important!!! EDIT: for the flyer2 I will separately answer on that issue!

mckillo commented 1 year ago

Thank you for testing the commit for this case. It can be closed.