jemproject / JEM-Project

JEM - an Event Manager for Joomla
https://www.joomlaeventmanager.net
GNU General Public License v3.0
25 stars 37 forks source link

ical button should be on calendar too #1657

Closed jojo12 closed 11 months ago

jojo12 commented 1 year ago

There are sites who prefere the calendar view, but for ical, they have to go to the simple list. They would prefere to have the ical button above the calendar (like the print button)

mckillo commented 11 months ago

20231029 JEM 411 - New ical icon in calendar view

@jojo12 Check it and if it's good, you can close this improve issue.

jojo12 commented 11 months ago

it seems, it integrates events only from one category. But the rest seems good.

mckillo commented 11 months ago

I have to review the case, because I think that I don't have any category filter. Let's me check it.

mckillo commented 11 months ago

It's fine. If you go the calendar view (FE) and download ical, the result file contains all events of this calendar for all categories. And if you use category filter, it works too. Tell me more details about any error.

mckillo commented 11 months ago

@jojo12 Tell me if you can download the events.ics file with several categories. If it's goood, you can close this issue.

jojo12 commented 11 months ago

now it works. one question: what about weekcalendar, venuecalendar and categorycalendar?

mckillo commented 11 months ago

Here you are, but this ics file doesn't include the category filter by JavaScript. Check it, a lot of changes (and code).

jojo12 commented 11 months ago

I tested:

mckillo commented 11 months ago

@jojo12 I have uploaded in the morning (1h ago) that part of this issue (yesterday I forgot to add in previous commit). See the commit 8135a641

mckillo commented 11 months ago

@jojo12 See last commit 9a162bef with the ical icon for venue calendar view.