jojo12 commented 3 months ago

I think, the fix for myevents is important (after all)!

mckillo commented 3 months ago

We could fix a date to release 4.2.1, and before close all issues possible. In 2 weeks?

jojo12 commented 3 months ago

Ok, I agree

mckillo commented 2 months ago

Check the JEM-4.2.1-dev, I think that it can be a release candidate of JEM 4.2.1 @hekla if you want, you can create a night.zip file in the root to test it before release (merge to master).

Heklaterriol commented 2 months ago

pkg_jem_nightly20240422.zip is created an uploaded: https://github.com/jemproject/JEM-Project/blob/JEM-4.2.1-dev/pkg_jem_nightly20240422.zip

mckillo commented 2 months ago

Thanks, How I told you, I have finish 2 commits, and they are uploaded (after your zip, sorry, yesterday I don't time in the night to finish).

Heklaterriol commented 2 months ago

Thank you. Do I get you right, that I can create the JEM 4.2.1 package now?

jobrusche commented 2 months ago

The changelog for 4.2.1 (https://www.joomlaeventmanager.net/project/changelog-jem-4) is already online but the package is not.

jojo12 commented 2 months ago

We're on the way: there's a nightly inside the branch 4.2.1dev.

mckillo commented 2 months ago

In my test of last zip, there are two issues:

JSession not found --->Fixed with commit: 035f6fea606c83182ca83bee2ed4f6fd4068e943 (review all JSession in front and back)
Error in queries with null from datetime field ---> Fixed with commit: e736a43e3788e25524c2addb604975892112d320 Please test it and inlcude these commits into final zip.

mckillo commented 2 months ago

In the next version 4.2.2, I have 4 pending issues:

new finder plugin (there is a new branch)
recurrence events edit
redesign attachment tab
time to start registration

Wishes to improve, although everything takes time.

Heklaterriol commented 2 months ago

A new nightly build is uploaded: https://github.com/jemproject/JEM-Project/blob/JEM-4.2.1-dev/pkg_jem_nightly20240424.zip

jojo12 commented 2 months ago

1719 is a new found problem!

Heklaterriol commented 2 months ago

Fixed, see https://github.com/jemproject/JEM-Project/commit/9d964e7be2ded5c01c066535888bc9f40a6f47c7

mckillo commented 2 months ago

I have done that last test in J4.4.4 & J5.1.0. I don't find more issue, it's stable, right? I think that the next night zip could be the final release 4.2.1. For me, you can publish when you want. Go to new branch JEM-4.2.2-dev

Heklaterriol commented 2 months ago

Ok fine. Thank you! @jojo12 When you give me your Go! too, then I will publish the release 4.2.1.

jojo12 commented 2 months ago

@Heklaterriol : Go! Thank you, both, for all your efforts!

Heklaterriol commented 2 months ago

JEM 4.2.1 package is created and in the repository. The branch JEM-4.2.1-dev is merged into master. A branch JEM-4.2.2-dev is created,

update_pkg_jem.xml is partly updated (information, release date, checksums) but not the link. The link (now https://www.joomlaeventmanager.net/download?download=124:jem-4-2-0-stable) has to be updated.

Who will upload the package and the updated update_pkg_jem.xml to the server?
Who will update extensions.joomla.org?

jojo12 commented 2 months ago

german transifex files are ready. There were 17 which were forgotten the last time and now 2 more.

Heklaterriol commented 2 months ago

@mckillo : You just committed some new changes. Are they for 4.2.2 or should I quickly include them in 4.2.1?

mckillo commented 2 months ago

You are free to add it (if on time) , I have uploaded to 4.2.2 because I think that the 4.2.1 was closed.

mckillo commented 2 months ago

Merge 4.2.2 to master or copy commits

Best way: move commits to 4.2.1 or merge 4.2.2 to 4.21, generate new zip 4.2.1, merge 4.2.1 to master again, and leave alive 4.4.2 to next commits.

jobrusche commented 2 months ago

Flemish (nl_BE) transifex files are ready. However I have some doubt about the translation of de date-string "j.m.y" . For nl_BE it would be "d.m.j"

Heklaterriol commented 2 months ago

Merge 4.2.2 to master or copy commits

Best way: move commits to 4.2.1 or merge 4.2.2 to 4.21, generate new zip 4.2.1, merge 4.2.1 to master again, and leave alive 4.4.2 to next commits.

done!

jojo12 commented 2 months ago

Ich komm nicht mehr draus! I don't understand nothing anymore!

Heklaterriol commented 2 months ago

Ich komm nicht mehr draus! I don't understand nothing anymore!

I added some commits to the JEM 4.2.1 package today, which come after the package creation of yesterday. The updated package is in the releases: https://github.com/jemproject/JEM-Project/releases/tag/v4.2.1-stable

jemproject / JEM-Project

Start of a 4.2.1 package? #1712

1719 is a new found problem!