search

jemproject / JEM-Project

JEM - an Event Manager for Joomla
https://www.joomlaeventmanager.net
GNU General Public License v3.0
25 stars 36 forks source link

Errors when uninstalling JEM-Package #1742

Closed Heklaterriol closed 1 week ago

Heklaterriol commented 2 months ago

There are problems with uninstalling JEM.

Each JEM item can be uninstalled individually without any problems.

But when uninstalling JEM-package there are problems: When I uninstall it, it uninstalls all the other items too (except Quickicons), but if the other items are already uninstalled, it causes error messages (even though they are uninstalled successfully). This also happens when I try to install all JEM elements at once, because they are uninstalled individually and at the same time JEM-Package tries to uninstall them again.

uninstall

I suggest that we modify the JEM package, that it only uninstalls itself and not all the other JEM items as well.

mckillo commented 2 months ago

If the admin uninstalls any JEM extension before uninstall JEM package, Joomla shows the warning. We don't have control of this Joomla warning. If the admin uninstalls JEM package, then all JEM extensions are uninstalled, include JEMm quickicon plugin (if the commit is applied).

mckillo commented 2 months ago

@Heklaterriol Thanks, now JEM uninstall is clean. Test it and if it works, close the issue.

mckillo commented 2 months ago

Extension Uninstall Dependency (https://docs.joomla.org/Package/en) "As of Joomla! 3.7.0, a package extension can declare that its child elements cannot be uninstalled independently with a true element in the package manifest. If your package needs all its extensions to operate effectively, set this to true or 1."

We can block to uninstall, but I think that it isn't necessary. The admin could uninstall JEM modules or plugins, if aren't used.

Heklaterriol commented 1 week ago

Thnx McKillo, I agree and I'm fine this way.