jen-kobrin
commented
7 years ago Thanks! I read through all of your comments and they are very helpful! Thank you for taking the time to review my code!
Open farishkash opened 7 years ago
jen-kobrin
commented
7 years ago Thanks! I read through all of your comments and they are very helpful! Thank you for taking the time to review my code!
Overall excellent. Your html was well organized. Yes your css was a little too repetitive but I hope my examples will guide you on how to stop some of that repetition. A couple nitpicks that I didn't feel worthy of putting an issue out there but will mention in the summary.
It would be nice if you had comments for each section of code in your html and css that stated the section name the code is referring too. It will make it faster to hop to that section when there is a bug or error in your code.
You never got your links working. They should be going to each section of the site.
Still excellent project. I would focus overall on being more efficient. It does take time to get to this point so this is more about things to build a foundation upon. In the final projects some of the css files are 400-500 lines long and I have reduce many lines by making one code change suggestion to the learners doing them.
As a challenge try using media queries to make this project look like an app when being viewed from a mobile phone device. This will help prepare you for the upcoming projects.