search

jenchanws / create-track-map

Create train track map mod for Minecraft (Fabric & Forge)
https://modrinth.com/mod/create-track-map
MIT License
65 stars 19 forks source link

Crash when interacting with other mods that use kotlinx.serialization because classes are not relocated #61

Open solonovamax opened 7 months ago

solonovamax commented 7 months ago

Describe the Bug

Due to the fact that kotlinx.serialization version 1.4.1 is shaded into the jar, but not relocated, this causes any mod that is compiled with the latest version of it to crash, as it will attempt to load kotlinx.serialization from create track map rather than, as it should be doing, from fabric language kotlin.

Please make sure to relocate your shaded dependencies, as well as depending on fabric language kotlin rather than shading it.

Reproduction Steps

  1. clone BeaconOverhaulReloaded, build mod from source.
  2. Create a new 1.20.1 minecraft instance with the following mods (I listed the version used, however any newer versions should suffice)
    • Cloth Config 11.1.118
    • Fabric Api 0.91.0+1.20.1
    • Fabric Language Kotlin 1.10.17+kotlin.1.9.22
    • Silk 1.10.1
    • ARRP (Advanced Runtime Resource Pack) 0.8.1
    • Create Fabric 0.5.1-d-build.1161+mc1.20.1
  3. Client successfully launches, so it's not an issue with the mods. Close game.
  4. Add Create Track Map 1.4+mc1.20.1-fabric
  5. Launch game
  6. Crash ""caused by"" beacon overhaul reloaded due to a method that does not exist.

Expected Result

Does not crash

Screenshots and Videos

N/A

Crash Report or Log

https://mclo.gs/1X2r6Sg

Operating System

Arch Linux 6.6.10-zen1-1-zen

CTM Version

1.4

Create Version

0.5.1d

Minecraft Version

1.20.1

Mod Loader

Fabric

Modloader Version

0.15.5

Instance Type

Singleplayer

Other Mods

Additional Context

No response