search

jenchanws / create-track-map

Create train track map mod for Minecraft (Fabric & Forge)
https://modrinth.com/mod/create-track-map
MIT License
65 stars 19 forks source link

Fix issues with shaded dependencies #62

Open solonovamax opened 7 months ago

solonovamax commented 7 months ago

Fixes #61.

Similar to #59.

fengshuo2004 commented 7 months ago

By the look of things, this PR would also fix my issue #65 . @jenchanws Please have a look. Thank you very much!

solonovamax commented 7 months ago

Hi, @fengshuo2004, this PR is only for the fabric 1.20 branch, as that was the version I was using. However, applying the same to the other branches should be quite easy, and I can do so if you'd like, as welll as providing instructions for how to compile it yourself so you can fix the issue.

However, mohist is not exactly the best and has many issues, so I also recommend giving this and this a read. Mohist can often be the cause for issues encountered, however I don't believe it is the issue here. But, often mohist is the cause of the issue.

fengshuo2004 commented 6 months ago

Hi, @fengshuo2004, this PR is only for the fabric 1.20 branch, as that was the version I was using. However, applying the same to the other branches should be quite easy, and I can do so if you'd like, as welll as providing instructions for how to compile it yourself so you can fix the issue.

However, mohist is not exactly the best and has many issues, so I also recommend giving this and this a read. Mohist can often be the cause for issues encountered, however I don't believe it is the issue here. But, often mohist is the cause of the issue.

@solonovamax Thanks for the reply. I am not using Mohist, I'm using Magma.

I'll clone your repo and make the same changes to the Forge branch. I have some Java dev experience so should figure this stuff out no problem. I'll let you know if it fixes my issue.

solonovamax commented 6 months ago

the same thing that was said about mohist applies to magma.

fengshuo2004 commented 6 months ago

Just coming back to say that after making my own build, this does indeed fix #65 . (Obviously the removal of the shadowDep line is not needed for Forge build since the line doesn't exist there anyway)

My opinion is, a patch is always nice to have as long as the patch doesn't break something else. But if Jen isn't willing to accept it, I'll just report the issue to Magma instead, no big deal.

In any case, thanks for the PR @solonovamax !

solonovamax commented 6 months ago

My opinion is, a patch is always nice to have as long as the patch doesn't break something else. But if Jen isn't willing to accept it, I'll just report the issue to Magma instead, no big deal.

in this particular instance, it is not an issue with magma

however, magma can cause many other issues, so it's basically the first thing you should check for issues.