Fixing bug #537, image filenames and web links are not included in wo…

jendrikseipp / rednotebook

RedNotebook is a cross-platform journal

https://rednotebook.app

GNU General Public License v2.0

477 stars 109 forks source link

Fixing bug #537, image filenames and web links are not included in wo… #696

Closed laraconda closed 2 months ago

laraconda commented 1 year ago

…rds cloud anymore.

Bug: #537

Summary of the changes in this pull request

Added regular expressions to exclude web links and files in the cloud of words.
Refactored the function "select_most_frequent_words".
TODO

Pull request checklist

[ ] I have added an entry in CHANGELOG.md including my name and issue and/or pull request number.
[ ] If applicable: I have removed the corresponding entry in TODO.md.

laraconda commented 1 year ago

I'm thinking about adding small tests for this. I should make a new file in tests/ right? Will tox automatically run it if its there?

jendrikseipp commented 1 year ago

Good idea! If it doesn't fit with some other tests that are already there, yes, please add a new test file. Tox will pick it up automatically.

laraconda commented 1 year ago

I tried to write a test for this functionality but since the class Cloud takes an instance of journal, I figured it would be complicated to instanciate Journal and insert simple text into it. @jendrikseipp do you think there's an easy way to do it?

jendrikseipp commented 1 year ago

I agree that testing this is too complicated. So no need to add a test here.

jendrikseipp commented 11 months ago

I'm assuming the ball is in your court. Give me a shout when you want me to review your changes.

jendrikseipp commented 2 months ago

Thanks @laraconda !