jendrikseipp / rednotebook

RedNotebook is a cross-platform journal
https://rednotebook.app
GNU General Public License v2.0
477 stars 109 forks source link

Debian Package Requires Incorrect Dependency; Warning report #713

Closed BlueNalgene closed 11 months ago

BlueNalgene commented 1 year ago

Describe the bug The Ubuntu package does not list Webkit2 4.1 as a dependency, leading to warnings. The package dependency should either demand gir1.2-webkit2-4.1 or not perform the Webkit2 version check.

To Reproduce

  1. Install rednotebook from the PPA without any custom dependencies.
  2. Run and observe warning.

Expected behavior

No warning.

Screenshots

Versions:

Log output when reproducing bug

INFO     Using GtkSourceView 4
Adding /usr/share/rednotebook to sys.path
INFO     Available versions of the WebKit2 namespace: ['4.0']
WARNING  WebKit2 4.1 not found. Trying to use arbitrary version. Error message: 'Namespace WebKit2 not available for version 4.1'
/usr/share/rednotebook/rednotebook/util/filesystem.py:59: PyGIWarning: WebKit2 was imported without specifying a version first. Use gi.require_version('WebKit2', '4.0') before import to ensure that the right version gets loaded.
  from gi.repository import WebKit2
INFO     Loaded version of the WebKit2 namespace: 4.0
INFO     Locale path: /usr/share/locale
[truncated for space]
kathenas commented 1 year ago

Hi,

The runtime dependency has to be on an API version webkit package and that is currently:

gir1.2-webkit2-4.0

The reason for this in Debian was to allow backports for Debian 11 (bullseye). Now we have the recent release of a new Debian stable 12 (bookworm) which has gir1.2-webkit2-4.1, the dependency for future releases can be updated.

Ubuntu 22.04 (jammy) has gir1.2-webkit2-4.1, so this is not an issue.

This change would end any backports for distribution versions prior to Debian 12 and Ubuntu 22.04. I do not see this as a problem for desktop/rednotebook users and users of Debian or Ubuntu as I would assume the use of recent versions.

I will personally change the dependency to gir1.2-webkit2-4.1 in the next release that goes into Debian and in turn that will be imported into Ubuntu. For Ubuntu 22.04.x I will prepare a backport and get it sponsored in.

Regards

Phil

kathenas commented 1 year ago

Hi,

The runtime dependency has to be on an API version webkit package and that is currently:

gir1.2-webkit2-4.0

The reason for this in Debian was to allow backports for Debian 11 (bullseye). Now we have the recent release of a new Debian stable 12 (bookworm) which has gir1.2-webkit2-4.1, the dependency for future releases can be updated.

Ubuntu 22.04 (jammy) has gir1.2-webkit2-4.1, so this is not an issue.

This change would end any backports for distribution versions prior to Debian 12 and Ubuntu 22.04. I do not see this as a problem for desktop/rednotebook users and users of Debian or Ubuntu as I would assume the use of recent versions.

I will personally change the dependency to gir1.2-webkit2-4.1 in the next release that goes into Debian and in turn that will be imported into Ubuntu. For Ubuntu 22.04.x I will prepare a backport and get it sponsored in.

Regards

Phil

See PR: https://github.com/jendrikseipp/rednotebook/pull/716

This will resolve the issue (you may need to manually install gir1.2-webkit2-4.1), but lead to an additional testing time requirement.

Regards

Phil