Remove spellcheck.py and use distro supplied pygtkspellcheck.

jendrikseipp / rednotebook

RedNotebook is a cross-platform journal

https://rednotebook.app

GNU General Public License v2.0

488 stars 110 forks source link

Remove spellcheck.py and use distro supplied pygtkspellcheck. #734

Open kathenas opened 10 months ago

kathenas commented 10 months ago

Version: git

Remove spellcheck.py and use distro supplied pygtkspellcheck.

On Debian, there is no supported distro version that does not have python3-gtkspellcheck >= 4.0.5.

Note: I have tested Debian sid with spellcheck.py removed and using the distro package with no issues.

jendrikseipp commented 10 months ago

The file is bundled because it contains 2-3 patches that probably only makes sense for RedNotebook (see git log -p rednotebook/external/spellcheck.py). Testing whether they're still needed and/or upstreaming them doesn't seem worth the effort to me. And making sure that all Linux distros, macOS and Windows have a version of pygtkspellcheck that works would take a lot of time.

kathenas commented 10 months ago

I can understand where you are coming from here. While having a patched version it is preferably to have it in the project code base. Over time I would hope time in the longer term can be made for a number of things.

Move to 5.0.x from upstream. Adds GTK 4 support amongst other things.
Checking if patches are still needed.
Test and approach upstream with possible bug fixes or applicable additions.

If the file could be removed one day with no headache, that would be good, but not something that is a must.

jendrikseipp commented 10 months ago

I agree that it would be nice to find time for this.