jbylund commented 4 years ago

Description

Vulture can mistake methods of child classes of string.Formatter as unused. Add a whitelist to deal with this.

Related Issue

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation in the README file.
[ ] I have updated the documentation accordingly.
[x] I have added an entry in NEWS.rst.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed. (py27 blew up locally with a CoverageException, and I can't install 3.5)

RJ722 commented 4 years ago

Thanks for the PR @jbylund!

The CI is failing weirdly. @jbylund are you getting this locally too?

jbylund commented 4 years ago

Yes, I'm getting this locally, but only for one python version.

RJ722 commented 4 years ago

The issue seems to be with coverage's latest release. I can reproduce this on master with Python 3.7.

jbylund commented 4 years ago

jendrikseipp commented 4 years ago

Regarding the tests: let's use coverage 4.5.x for now.

Regarding the changelog: I'll add your name.

Thanks again for looking into this!