jendrikseipp / vulture

Find dead Python code
MIT License
3.48k stars 152 forks source link

add trove classifier for py38 #213

Closed ju-sh closed 4 years ago

ju-sh commented 4 years ago

Description

Add trove classifier for Python3.8

Add trove classifier for Python3.8. Thought it was too small a change to be creating an issue.

As an aside, can't we open the files, read its contents, assign it to a variable and use that variable in the long_description argument to setup() in setup.py instead of opening it then and there?

Related Issue

Checklist:

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 762


Totals Coverage Status
Change from base Build 761: -1.0%
Covered Lines: 597
Relevant Lines: 603

💛 - Coveralls
jendrikseipp commented 4 years ago

Thanks!

As an aside, can't we open the files, read its contents, assign it to a variable and use that variable in the long_description argument to setup() in setup.py instead of opening it then and there?

Yes, I guess we could. Feel free to make the change.