Setup py - Githubissues

jendrikseipp / vulture

Find dead Python code

MIT License

3.41k stars 150 forks source link

Setup py #224

Closed ju-sh closed 4 years ago

ju-sh commented 4 years ago

Description

I had a few simple suggestions regarding the setup.py file.

Use pathlib instead of os.path
Remove usage of codecs.open
Since read() is not used anywhere else, combine it with find_version().

Related Issue

Didn't open an issue for this since the changes were minor.

Checklist:

[ ] My code follows the code style of this project.
[x] I have updated the documentation in the README.md file.
[ ] I have added an entry in CHANGELOG.md.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

jendrikseipp commented 4 years ago

Thanks! The read_text() method is nice! I didn't even know about it. If you like, feel free to look into using pathlib for the main Vulture code :-)

ju-sh commented 4 years ago

Sure, I will give it a try. :-)