search

jendrikseipp / vulture

Find dead Python code
MIT License
3.48k stars 152 forks source link

Use pathlib #226

Closed ju-sh closed 4 years ago

ju-sh commented 4 years ago

Use pathlib

Description

Related Issue

Mentioned at https://github.com/jendrikseipp/vulture/pull/224.

Checklist:

ju-sh commented 4 years ago

Hi.

Coverage has reduced but I thought it was better to see if the changes were okay before adding to the tests as I have probably broken something.

ju-sh commented 4 years ago

Sorry for the delay. Got held up with something else in between.

I had ended up adding annotations to help me figure out the changes to make. I've removed them.

But, as an aside, I think it's good to have type annotations. They can really help a lot while making changes. Even when we don't do static type checking.

Let me know of further changes so we can go ahead and squash the commits.

jendrikseipp commented 4 years ago

Thanks for your work on this!