search

jendrikseipp / vulture

Find dead Python code
MIT License
3.48k stars 152 forks source link

Add tests for python3.9 #236

Closed ju-sh closed 4 years ago

ju-sh commented 4 years ago

Add tests for python3.9

Description

Test for the new Python version in tox and github actions.

The new version doesn't seem to break anything.

https://docs.python.org/3.9/whatsnew/3.9.html

Related Issue

Checklist:

jendrikseipp commented 4 years ago

Nice, thanks!

jendrikseipp commented 4 years ago

I was a bit quick to merge this... Due to a syntax error in the GitHub action, your tests never ran. After fixing the error, the test for Pypy on Windows fails (https://github.com/jendrikseipp/vulture/runs/1222113460?check_suite_focus=true). Could you look into this, please @ju-sh ? If you can't find a fix, please skip the Pypy on Windows test in the GitHub Action.

jendrikseipp commented 4 years ago

It seems this isn't related to your changes at all. Would yo care to investigate nonetheless?

ju-sh commented 4 years ago

I looked through some pages, but couldn't find a fix for this.

Maybe we moved too quick and perhaps some actions has incompatibility with new version maybe? Still the failing test had passed earlier with what seems to be the same pypy version.

I wonder what's going wrong.. :-(

ju-sh commented 4 years ago

It seems this isn't related to your changes at all. Would yo care to investigate nonetheless?

I'll try. Which github action error had you set right earlier though? Was it the setup python?

jendrikseipp commented 4 years ago

I'm not sure what you mean. The error has nothing to do with our changes. Only with some version of a dependency which was updated behind our back. Could you try to pin the tox version to an earlier release?

ju-sh commented 4 years ago

No you mentioned a syntax error. I just wanted to know where the error was in. Was just curious to know if it was in a github action's code or in the main.yml file.

jendrikseipp commented 4 years ago

There was an extra [ in the main.yml file. I looked at the logs of the last successful and the first failing build and the only difference is the minor Windows version. I think the best strategy is to skip the tests for Pypy on Windows for now. Can you try that, please?

ju-sh commented 4 years ago

Shall I create a new PR after removing pypy on windows? Commits to the branch of this PR is not showing up here.

And is there a way to try out github action without having to push to github every time?

jendrikseipp commented 4 years ago

Yes and no 😊

The-Compiler commented 4 years ago

And is there a way to try out github action without having to push to github every time?

FWIW there's act, but I've never actually tried it, and it doesn't seem to support Windows.

jendrikseipp commented 4 years ago

Thanks for the hint! Didn't know about this tool. It looks quite useful!