search

jendrikseipp / vulture

Find dead Python code
MIT License
3.48k stars 152 forks source link

doc: hotfix pre-commit instructions #245

Closed neutrinoceros closed 3 years ago

neutrinoceros commented 3 years ago

This is a hotfix to #244, fixing an important mistake in README.md

codecov-io commented 3 years ago

Codecov Report

Merging #245 (b2cfcb5) into master (3d5b799) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files          17       17           
  Lines         631      631           
=======================================
  Hits          627      627           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d5b799...b2cfcb5. Read the comment docs.

jendrikseipp commented 3 years ago

Good catch, thanks!

pquentin commented 3 years ago

Thanks, I was about to report that! (Note that the quotes aren't needed: since there's a v in the string, it cannot be mistaken for a number.)

neutrinoceros commented 3 years ago

Thank you for the clarification, I never quite understood why it was sometimes necessary but not always :)