search

jendrikseipp / vulture

Find dead Python code
MIT License
3.38k stars 148 forks source link

Add some pandas functions whitelist #262

Closed mathbunnyru closed 2 years ago

mathbunnyru commented 3 years ago

Description

I added some pandas functions as a whitelist

codecov-commenter commented 3 years ago

Codecov Report

Merging #262 (c803a25) into master (32ff46c) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files          18       19    +1     
  Lines         635      640    +5     
=======================================
+ Hits          631      636    +5     
  Misses          4        4
Impacted Files Coverage Δ
vulture/whitelists/pandas_whitelist.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 32ff46c...c803a25. Read the comment docs.

jendrikseipp commented 3 years ago

Thanks for the PR! There's one failing test for pypy3 on macos-10.15. I think the easiest solution is to skip testing the pandas whitelist for pypy3 on macos-10.15. Could you please look into how best to skip the test?

mathbunnyru commented 3 years ago

Yes, I will do that couple of days later, I hope :)