Closed chayim closed 2 years ago
I haven't executed on all the items within the checklist as tests and tox style checks seem to not apply here.
Merging #266 (bdd6541) into master (6ffd70a) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #266 +/- ##
=======================================
Coverage 99.37% 99.37%
=======================================
Files 18 18
Lines 635 635
=======================================
Hits 631 631
Misses 4 4
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6ffd70a...bdd6541. Read the comment docs.
Thanks for the PR! Before marking Python 3.10 as supported, I'd like to enable CI tests for it, however. Do you think you could make the necessary changes (in tox.ini and .github/workflows/main.yml)? Afterwards, please add an entry to the changelog.
Perfect, happy to, I just didn't want to presume ;). It's included in the latest push.
It seems the tests are not passing. Can you look into this, please?
Looks good. Thanks!
Added a python 3.10 trove for pypi - as I'm running this without issue in CI with 3.10.
tox -e fix-style
to format my code and checked the result withtox -e style
.