search

jendrikseipp / vulture

Find dead Python code
MIT License
3.38k stars 148 forks source link

False positive example should be updated #272

Closed yoichi closed 1 year ago

yoichi commented 2 years ago

Follow the instruction in README.md with vulture >= 2.1 results:

$ vulture dead_code.py
dead_code.py:1: unused import 'os' (90% confidence)
dead_code.py:8: unused variable 'message' (60% confidence)

It does not detect

dead_code.py:4: unused function 'greet' (60% confidence)

as expected since https://github.com/jendrikseipp/vulture/pull/219 eliminates the false positive.

I think it would be good to update the example to something that can still be reproduced.

RJ722 commented 2 years ago

Thanks for the report, @yoichi! I'll get a fix up for this.

jendrikseipp commented 1 year ago

Fixed now. Thanks for the report!