Open mirecl opened 1 year ago
Merging #310 (068185c) into main (e2e84d0) will decrease coverage by
0.59%
. The diff coverage is33.33%
.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## main #310 +/- ##
==========================================
- Coverage 98.94% 98.36% -0.59%
==========================================
Files 21 21
Lines 665 671 +6
==========================================
+ Hits 658 660 +2
- Misses 7 11 +4
Impacted Files | Coverage Δ | |
---|---|---|
vulture/core.py | 97.40% <33.33%> (-1.13%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@jendrikseipp, what do you think? will it be useful for the project?
Thanks for the PR! It'll take me a while until I can review it properly. Two quick notes:
If you can rework the PR in these directions, that'll help getting it merged. If you already check both of these, all the better :-)
@jendrikseipp, since this is a new feature - backwards compatibility should remain in full for option exclude files.
Option exclude files with ./
must not conflict with flake8 and black. But the current option exclude files approach definitely contradict flake8 and black:
https://github.com/jendrikseipp/vulture/blob/e2e84d0a63201742ccee4bfcbe7ab065ed100f2c/vulture/core.py#L263-L266
@jendrikseipp, pls tell us how the progress on this PR is going:)
@jendrikseipp, what is the status of PR?
@mirecl Are you still planning to work on this?
Description
AS-IS:
Currently, there’s no way to specify concrete path in exclude section, this is due to Vulture will always add
*
to both start and end of the string: https://github.com/jendrikseipp/vulture/blob/e2e84d0a63201742ccee4bfcbe7ab065ed100f2c/vulture/core.py#L263-L266TO-BE:
Now, prefixing exclude value with
./
will resolve to full specific path:Checklist:
tox -e fix-style
to format my code and checked the result withtox -e style
.