jendrikseipp / vulture

Find dead Python code
MIT License
3.29k stars 145 forks source link

The pre-commit autoupdate downgrades to v2.11 #351

Closed akomisarek closed 4 months ago

akomisarek commented 4 months ago

It seems vulture doesn't property maintains the version from the perspective of pre-commit tool.

Adding the following:

-   repo: https://github.com/jendrikseipp/vulture
    rev: v2.11
    hooks:
    -   id: vulture

And running pre-commit autoupdate results in:

[https://github.com/jendrikseipp/vulture] updating v2.11 -> v2.10

Any hints?

jendrikseipp commented 4 months ago

Thanks for the report! Unfortunately, I don't see what could be the reason for this behavior.

akomisarek commented 4 months ago

Thanks for the reply. Ok when I have a sec I will try to debug this, and try to spot the issue!

paveltsialnou commented 4 months ago

probably you just need to add tag in main:

$ git log --all --decorate --graph --oneline -10
* d8c5934 (HEAD -> main, origin/main, origin/HEAD) Fix changelog format.
* d47dcdc Use ruff for formatting (#349)
* 539761e Fix typo.
* f5cf4e6 Update changelog.
* aa42062 Use ruff for linting (#347)
| * 35d2263 (tag: v2.11) Update version number to 2.11 for release.
| * a0f536c Update changelog.
|/  
* e20349b Revert "Read exclude patterns from .gitignore in absence of user-provided patterns (#344) (#345)"
* 458be54 Bugfix: Handle when .gitignore is not present. (#346)
* aa6fcd2 Read exclude patterns from .gitignore in absence of user-provided patterns (#344) (#345)
jendrikseipp commented 4 months ago

Thanks! I merged the two diverging branches. Does it work for you now?

paveltsialnou commented 4 months ago

yep

jendrikseipp commented 4 months ago

Great!