jendrikseipp / vulture

Find dead Python code
MIT License
3.29k stars 145 forks source link

The conda package for `vulture` is unmaintained #355

Open Zeitsperre opened 2 months ago

Zeitsperre commented 2 months ago

It appears that the conda package for vulture is lagging by several versions: https://github.com/conda-forge/vulture-feedstock/pulls

I'll open a Pull Request here to add a version badge for conda-forge, so that that happens less often.

Thanks for building this neat library!

jendrikseipp commented 2 months ago

Thanks for the report and the PR! But wouldn't it be better to have some kind of mechanism that informs the maintainers of the conda Vulture package about new Vulture releases? I guess such a system already exists, right?

Zeitsperre commented 2 months ago

I maintain a fair number of conda packages, and "watching" the feedstock and getting tagged on bot-generated Pull Requests is usually enough for me. You should add your name to the maintainers list of the conda package! https://conda-forge.org/docs/maintainer/infrastructure/#conda-forge-admin-please-add-user-username

If the dependencies aren't changing between versions, there's also the option of enabling auto-merge as well.

jendrikseipp commented 2 months ago

Ah, I think we misunderstood each other: I don't have the bandwidth to maintain the Vulture conda-forge. My hope is that someone from the conda community takes up that task.

Zeitsperre commented 2 months ago

Gotcha. If the current maintainer (@jakirkham) is willing to extend access to me, I don't mind adding this to the list of projects I help maintain on conda-forge.

Once the package is fast-forwarded on conda-forge, we can safely merge #356. Would that be an acceptable solution? I'd like to see this project up-to-date in some of my conda-only environments.

jakirkham commented 2 months ago

Would happily welcome the help 🙂

Thanks Trevor! 🙏

Would suggest opening a new PR updating vulture in conda-forge to the latest version and adding yourself as a maintainer. Then we can go from there

Zeitsperre commented 2 months ago

@jakirkham I just need your approval and merge here (https://github.com/conda-forge/vulture-feedstock/pull/28) and I can take a few minutes to clean things up. All the best!