search

jenil / bulmaswatch

Themes for Bulma
https://jenil.github.io/bulmaswatch
MIT License
1.64k stars 144 forks source link

Fix Select bottom border for Lumen #87

Open Shashwat986 opened 3 years ago

Shashwat986 commented 3 years ago

The height of the select tag is larger than other elements. This is vastly more prominent in form elements grouped using has-addons. This PR fixes that.

Old:

Screen Shot 2020-10-08 at 6 50 53 PM

New:

Screen Shot 2020-10-08 at 6 50 17 PM
Shashwat986 commented 3 years ago

Also, quick request. I'm participating in Hacktoberfest, and I'd love for this PR to be eligible for that:

Your PR was submitted to a repository that is not participating in Hacktoberfest. Maintainers of the repository can add the "hacktoberfest" topic to their repository if they wish to participate. Alternatively, an individual PR can be opted-in with a maintainer adding the "hacktoberfest-accepted" label to the PR.

RubyHuntsman commented 3 years ago

Can you also fix big search button from second input?

Shashwat986 commented 3 years ago

Good catch! I've added a commit for that too. (Image has is-small for the first element, because I was testing it too)

Screen Shot 2020-10-17 at 11 02 13 AM
RubyHuntsman commented 3 years ago

Now looks great